Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Version Catalogs #17

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Chore: Version Catalogs #17

merged 1 commit into from
Jun 29, 2022

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Jun 29, 2022

Ready for review Powered by Pull Request Badge

This changeset cleans up and refactors the build structure to work with Gradle Version Catalogs, and integrates the Elide Plugin for Gradle into the main build.

Changes enclosed:

  • Assemble main catalog and fixup all deps/plugins to use it
  • Embed protocol buffers for page/media/semantic use (Elide v2)
  • Embed Gradle plugin as sub-build

@sgammon sgammon added dependencies Pull requests that update a dependency file tools Issues and PRs related to tooling labels Jun 29, 2022
@sgammon sgammon added this to the Alpha 1: Initial Release milestone Jun 29, 2022
@sgammon sgammon self-assigned this Jun 29, 2022
Base automatically changed from feat/js-prepack to v3 June 29, 2022 00:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #17 (55bca5a) into v3 (4168ba8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                 v3      #17   +/-   ##
=========================================
  Coverage     59.45%   59.45%           
  Complexity      166      166           
=========================================
  Files            33       33           
  Lines          1349     1349           
  Branches        132      132           
=========================================
  Hits            802      802           
  Misses          526      526           
  Partials         21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4168ba8...55bca5a. Read the comment docs.

This changeset cleans up and refactors the build structure to work
with Gradle Version Catalogs, and integrates the Elide Plugin for
Gradle into the main build.

Changes enclosed:
- Assemble main catalog and fixup all deps/plugins to use it
- Embed protocol buffers for page/media/semantic use (Elide v2)
- Embed Gradle plugin as sub-build
@sgammon sgammon force-pushed the feat/version-catalogs branch from 782c644 to 55bca5a Compare June 29, 2022 00:56
@sgammon sgammon marked this pull request as ready for review June 29, 2022 00:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sgammon sgammon merged commit 56937d7 into v3 Jun 29, 2022
@sgammon sgammon deleted the feat/version-catalogs branch June 29, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file tools Issues and PRs related to tooling
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants